cgo signature verification not supported & cannot use privkey verify signature

[ningxin18]

Summary of Bug

secp256k1_cgo issue

Although I used +build !libsecp256k1, but secp256k1_cgo signature veryfication not supported.

line 24 in secp256k1_cgo.go, there's cannot use private key verify signature

func (pubKey *PrivKey) VerifySignature(msg []byte, sig []byte) bool {
	return secp256k1.VerifySignature(pubKey.Key, crypto.Sha256(msg), sig)
}

change as below

func(pubkey *PubKey) VerifySignature(msg []byte, sig []byte) bool {
	return secp256k1.VerifySignature(pubkey.Bytes(), crypto.Sha256(msg), sig)
}

secp256k1_cgo sig verifiction issue

when I use ethereum verify signature:

  msg := []byte("We have lingered long enough on the shores of the cosmic ocean.")
  
  msg = crypto.Keccak256(msg)
  key, _ := ecdsa.GenerateKey(secp256k1.S256(), rand.Reader)
  priv2 :=math.PaddedBigBytes(key.D, 32)
  
  signature, err2 := secp256k1.Sign(msg, priv2)
  require.Nil(t, err2)
  
  
  time1 := time.Now()
  pubkey := elliptic.Marshal(secp256k1.S256(), key.X, key.Y)
  ok := secp256k1.VerifySignature(pubkey, msg, signature[:64])
  fmt.Println("time:", time.Now().Sub(time1).Microseconds()) 

ethereum cgo average verification time is 60 ms

but cosmos go sig verification takes 350 ms, cgo sig verification takes 180 ms

  msg := []byte("We have lingered long enough on the shores of the cosmic ocean.")
  
  priv := GenPrivKey()
  sigStr, err := priv.Sign(msg)
  require.NoError(t, err)
  
  pub := priv.PubKey()
  
  time1 := time.Now()
  ok := pub.VerifySignature(msg, sigStr[:64])
  fmt.Println("time:", time.Now().Sub(time1).Microseconds())

Version

Every release

Steps to Reproduce

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[tac0turtle]

can you explain if you need ego verification? As a team we talked about deprecating and removing the ego version in favour of the native go one, but this is because we did not know of a user for it

[ningxin21]

can you explain if you need ego verification? As a team we talked about deprecating and removing the ego version in favour of the native go one, but this is because we did not know of a user for it

We use cosmos-sdk develop dex, so we need maximize performance.
As you can see, the test above shows that cgo-version can double the performance.

[tac0turtle]

cc @ValarDragon do you have any idea why cosmos ego is so much slower as well?

[ValarDragon]

I believe Eth's CGO implementation now takes advantage of GLV optimizations. It was in bitcoin core for ages, but not in Ethereum due to patent issues. The patent expired sometime in the last two years, and then Ethereum switched is my understanding.