tx committed successfully but return failure result

[yihuang]

When the last tx in a block exceeds the block gas limit, it returns an error result, but the tx is actually committed successfully.

Summary of Bug

Version

Steps to Reproduce

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[amaury1093]

@yihuang did you check if this is present on 0.42 and 0.44 too? Or it this related only to the middleware refactor (#9996)?

[tomtau]

@AmauryM AFAIK it is in both 0.42 and 0.44:
https://github.com/cosmos/cosmos-sdk/blob/v0.42.11/baseapp/baseapp.go#L599
https://github.com/cosmos/cosmos-sdk/blob/v0.44.5/baseapp/baseapp.go#L609

(the issue was discovered on 0.44)

[tomtau]

a write up from @colin-axner:

Summary of Bug

A tx being executed which causes the block gas limit to be reached will be persisted, but its response information will be wiped and replaced with a code 11 error: out of gas in location: block gas meter; gasWanted: 0, gasUsed: 224156: out of gas

No events are emitted.

How the bug was found

An issue was reported of a IBC packet being relayed but no events existing for that packet sequence. Our state information indicated that the packet had been relayed. No associated transaction could be found by querying for events.

After debugging the issue, the block the packet was relayed in was determined and the associated tx was found. The transaction had caused state changes, but all events were wiped from the response. The response might look something like:

gaiad q tx --type=hash C1B2FB06C8FA42E36D4C1147B2E7C8BFDA74A960CE245E917339EAC1F2D5D47C --node http://localhost:27000
code: 11
codespace: sdk
data: ""
gas_used: "224156"
gas_wanted: "0"
height: "2"
info: ""
logs: []
raw_log: 'out of gas in location: block gas meter; gasWanted: 0, gasUsed: 224156:
  out of gas'

I confirmed this issue by replicating my suspicions. I created 2 chains and set 1 chain to have a max block gas of 1. I sent a create client IBC tx and got the expected response. The client had been created, but no events existed in state for the transaction.

Version

v0.44.3

Steps to Reproduce

1. Construct a chain with max_gas genesis parameter set to 1
2. Submit any tx that is expected to succeed (failing txs untested). Note the error message and the persisted state changes.

Expected Behaviour

The tx should either by rejected (and the state changes discarded) or the tx should be accepted and the full response returned.