Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gov v1beta2 remove deprecated Vote.option #10792

Closed
4 tasks
amaury1093 opened this issue Dec 16, 2021 · 0 comments · Fixed by #10854
Closed
4 tasks

Gov v1beta2 remove deprecated Vote.option #10792

amaury1093 opened this issue Dec 16, 2021 · 0 comments · Fixed by #10854
Assignees
@atheeshp
Labels
C: Proto Proto definition and proto release C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@amaury1093
Copy link
Contributor

Summary

We deprecated this field in v1beta1. Let's remove it in v1beta2.

cosmos-sdk/proto/cosmos/gov/v1beta2/gov.proto

Lines 88 to 91 in 914af60

// Deprecated: Prefer to use `options` instead. This field is set in queries
// if and only if `len(options) == 1` and that option has weight 1. In all
// other cases, this field will default to VOTE_OPTION_UNSPECIFIED.
VoteOption option = 3 [deprecated = true];

Problem Definition

Remove deprecated field.

Proposal

I think it's worth keeping field 3 as reserved still.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C: Proto Proto definition and proto release labels Dec 16, 2021
@amaury1093 amaury1093 mentioned this issue Dec 16, 2021
Merged
19 tasks
@atheeshp atheeshp self-assigned this Dec 16, 2021
@atheeshp atheeshp mentioned this issue Dec 31, 2021
Merged
19 tasks
@cmwaters cmwaters moved this to In Progress in Cosmos SDK: Gov & Group WG Jan 11, 2022
@mergify mergify bot closed this as completed in #10854 Jan 26, 2022
mergify bot pushed a commit that referenced this issue Jan 26, 2022
@atheeshp
refactor: remove deprecated vote option (#10854)
8133ee8 
## Description

Closes: #10792



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Repository owner moved this from In Progress to Done in Cosmos SDK: Gov & Group WG Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
C: Proto Proto definition and proto release C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
No open projects
Cosmos SDK: Gov & Group WG
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove deprecated vote option cosmos/cosmos-sdk
2 participants
@amaury1093 @atheeshp