Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1beta1 Query server to gov #10951

Closed
4 tasks
amaury1093 opened this issue Jan 14, 2022 · 0 comments · Fixed by #11029
Closed
4 tasks

Add v1beta1 Query server to gov #10951

amaury1093 opened this issue Jan 14, 2022 · 0 comments · Fixed by #11029
Assignees
@cmwaters
Labels
C:x/gov

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Jan 14, 2022 •
edited
Loading

Summary

We switched to v1beta2 query server in #10868. We should add the v1beta1 one too for backwards-compatibility.

Proposal

Same as for msgServer, we should create a v1beta1 query server that wraps around a v1beta2 one, and just proxies requests to the v1beta2 one.

Add some tests to make sure both query servers work.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 mentioned this issue Jan 14, 2022
Merged
19 tasks
@amaury1093 amaury1093 assigned amaury1093 and unassigned amaury1093 Jan 24, 2022
@cmwaters cmwaters self-assigned this Jan 26, 2022
@cmwaters cmwaters mentioned this issue Jan 26, 2022
Merged
19 tasks
@amaury1093 amaury1093 moved this from Ready to In Progress in Cosmos SDK: Gov & Group WG Jan 26, 2022
@amaury1093 amaury1093 moved this from In Progress to In Review in Cosmos SDK: Gov & Group WG Jan 31, 2022
Repository owner moved this from In Review to Done in Cosmos SDK: Gov & Group WG Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

Labels
C:x/gov
Projects
No open projects
Cosmos SDK: Gov & Group WG
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: v1beta1 gov query server cosmos/cosmos-sdk
2 participants
@amaury1093 @cmwaters