Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v1beta1 gov query server #11029

Merged
merged 15 commits into from
Feb 1, 2022
Merged

Conversation

cmwaters
Copy link
Contributor

Description

Closes: #10951

Implements the legacy v1beta1 query server which wraps the new query server.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@cmwaters cmwaters marked this pull request as ready for review January 28, 2022 09:14
Comment on lines +721 to +725
defaultTallyParams := v1beta1.TallyParams{
Quorum: sdk.NewDec(0),
Threshold: sdk.NewDec(0),
VetoThreshold: sdk.NewDec(0),
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I need to do this - but the tests won't pass if I just use v1beta1.TallyParams{}

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, have a couple of questions around error handling

x/gov/migrations/v046/migrate.go Outdated Show resolved Hide resolved
x/gov/migrations/v046/migrate.go Outdated Show resolved Hide resolved
x/gov/migrations/v046/migrate.go Show resolved Hide resolved
x/gov/migrations/v046/migrate.go Outdated Show resolved Hide resolved
x/gov/migrations/v046/migrate.go Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2022

This pull request introduces 1 alert when merging c79312c into 428ae3c - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending changelog #11029 (comment).

Re #11029 (comment), have a small preference for error w/ migration path, but since it's a deprecated endpoint, we can leave the current implementation.

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2022

This pull request introduces 1 alert when merging 3da0003 into dd0d712 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@blushi blushi self-assigned this Jan 31, 2022
@cmwaters cmwaters merged commit df36a6f into master Feb 1, 2022
@cmwaters cmwaters deleted the callum/legacy-gov-query-server branch February 1, 2022 18:25
mergify bot pushed a commit that referenced this pull request Feb 3, 2022
## Description

Closes: #10869

depends on: 
- [x] #11029 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add v1beta1 Query server to gov
3 participants