Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--dry-run not worked when use tx command #11149

Closed
4 tasks
bruce-wayne2 opened this issue Feb 9, 2022 · 3 comments · Fixed by #11558
Closed
4 tasks

--dry-run not worked when use tx command #11149

bruce-wayne2 opened this issue Feb 9, 2022 · 3 comments · Fixed by #11558
Assignees
@julienrbrt
Labels
C:CLI T:Bug

Comments

@bruce-wayne2
Copy link
Contributor

bruce-wayne2 commented Feb 9, 2022 •
edited
Loading

Summary of Bug

When use --dry-run,eg: simd tx bank send alice $(simd keys show bob -a) 10000xxx --from alice --fees 10xxx --dry-run,
the application will report an error: Error: alice.info: key not found.

> simd keys list
- name: alice
  type: local
  address: xxx
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A5LkJf54y3PYWpV6j07TODZMDJl8Nio/MEbLiNivUEgS"}'
  mnemonic: ""
- name: andy
  type: local
  address: xxx
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"ApObXlyyCd3ktwl5M6NLOec+FK5xMPlBfA/0t2IVshaT"}'
  mnemonic: ""
- name: bob
  type: local
  address: xxx
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A9b4f781REkAV3QI/+ka2D1FwKZiHhX0u5f6aHZaTNhl"}'
  mnemonic: ""

Version

v0.44.5

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

Are you sure you're using the correct --home and --keyring-backend?

@bruce-wayne2
Copy link
Contributor Author

I use the default parameters: home and keyring-backend.
If I remove the --dry-run parameter, it worked for me.

@de-husk de-husk mentioned this issue Feb 23, 2022
Closed
@julienrbrt julienrbrt self-assigned this Apr 1, 2022
@amaury1093 amaury1093 moved this to In Progress in Cosmos SDK Maintenance Apr 1, 2022
@nooomski
Copy link
Contributor

nooomski commented Apr 4, 2022 •
edited
Loading

Running into the same problem, found this issue and wanted to confirm I can reproduce. Tried bank and vesting Txs, using --home and --keyring-backend. Any Tx without --dry-run work fine.

Using v0.46.0-beta1

@julienrbrt julienrbrt mentioned this issue Apr 6, 2022
Merged
19 tasks
@julienrbrt julienrbrt linked a pull request Apr 6, 2022 that will close this issue
fix: --dry-run not working when using tx command #11558
Merged
19 tasks
@blushi blushi moved this from In Progress to In Review in Cosmos SDK Maintenance Apr 7, 2022
@mergify mergify bot closed this as completed in #11558 Apr 11, 2022
mergify bot pushed a commit that referenced this issue Apr 11, 2022
@julienrbrt
fix: --dry-run not working when using tx command (#11558)
4f1cc3a 
## Description

Closes: #11149

- Let `--dry-run` not use the local keyring
- Fixes for required flags not shown
- Make `--generate-only` behavior consistent
---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Repository owner moved this from In Review to Done in Cosmos SDK Maintenance Apr 11, 2022
0Tech added a commit to Finschia/finschia that referenced this issue Aug 10, 2022
@0Tech
Comment out dry-run for now (cosmos/cosmos-sdk#11149)
96920ad
0Tech added a commit to Finschia/finschia that referenced this issue Aug 10, 2022
@0Tech
Comment out dry-run for now (cosmos/cosmos-sdk#11149)
9998169
0Tech added a commit to Finschia/finschia that referenced this issue Aug 17, 2022
@0Tech
test: enable tests on CI (#83)
8269c11 
* Remove the force flag

Since it's not working anymore.

* Update the arguments for `TokenFromConsensusPower()`

* Fix add-genesis-account

* Update addresses and keys

* Fix marshalling

* Pass min gas price

* Revert sig-block-height

* Comment out dry-run for now (cosmos/cosmos-sdk#11149)

* Change QueryTxs output into json

* Update to FlagNote (cosmos/cosmos-sdk#9122)

* Update the value of message.action to the latest's

* Add --no-admin flag

* Add /lbm.stakingplus.v1.CreateValidatorAuthorization related logic

* Disable GRPC web

* Lint

* Update the test flow

* Disable diff

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
C:CLI T:Bug
Projects
No open projects
Cosmos SDK Maintenance
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: --dry-run not working when using tx command cosmos/cosmos-sdk
4 participants
@alexanderbez @julienrbrt @nooomski @bruce-wayne2