Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subpackages in modules #1124

Closed
rigelrozanski opened this issue Jun 2, 2018 · 5 comments · Fixed by #4451
Closed

Subpackages in modules #1124

rigelrozanski opened this issue Jun 2, 2018 · 5 comments · Fixed by #4451

Comments

@rigelrozanski
Copy link
Contributor

This issue is specifically referencing how complex staking is, and that we should split in up.

General Proposed Design Approach:
In the same vein as #1123 - /x modules with substantial amounts of logic should probably be split into multiple packages - but then aliases created in x/your-module/types.go so that as an external user of the module, I don't need to understand the inner structures of effectively reference it's types

CC: @cwgoes

@cwgoes
Copy link
Contributor

cwgoes commented Jun 2, 2018

We shouldn't overuse this, but I agree that it makes sense right now for x/staking, and could make sense in the future for other modules of similar complexity.

@sunnya97
Copy link
Member

@rigelrozanski Can we close this issue?

@rigelrozanski
Copy link
Contributor Author

Not prelaunch, but I think we should keep open - I think both slashing and gov should be reorganized to use subdir. As gov expands with more features this will become more useful as well.

@jackzampolin
Copy link
Member

Going to close this as addressed by the module refactor.

@rigelrozanski
Copy link
Contributor Author

rigelrozanski commented May 28, 2019

only once #4296 has been merged should this issue be closed (which is will be automatically by the PR right)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants