Subpackages for x/modules

[rigelrozanski]

organize core modules to have sub-packages (see x/stake which has been organized this way) - it's really good to set the this type of structure early on in the development - I know slashing and governance are probably going to grow up to be big complicated machines, doing this refactor for staking (which was quite mature at the time) was a bit of a headache I think we should perform a similar refactors for gov and slashing at a minimum in the short term to alleviate future migraines.

@sunnya97 @cwgoes

[cwgoes]

I'm not convinced the slashing module will get much more complicated - most of the complicated slashing logic is in the staking module, since it needs access to un-exported keeper functions - maybe we could consider refactoring that somehow.

Agreed for governance, and for slashing if we think it will get more complicated; at the moment I think slashing subpackages would be overkill.

[rigelrozanski]

cool - you should def. make the judgement call for x/slashing - I will mention however, that if things start creeping to be more complex in slashing, at that point we should first refactor

[jackzampolin]

I think @rigelrozanski's recent PR refactoring the modules handles this. Going to go ahead and close.

[rigelrozanski]

duplicate of #1124