Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the tendermint inspect CLI to the SDK #11495

Closed
4 tasks
JayT106 opened this issue Mar 29, 2022 · 5 comments · Fixed by #11548
Closed
4 tasks

Wrap the tendermint inspect CLI to the SDK #11495

JayT106 opened this issue Mar 29, 2022 · 5 comments · Fixed by #11548

Comments

@JayT106
Copy link
Contributor

JayT106 commented Mar 29, 2022

Summary

looks like the current SDK, e3c3467, doesn't have integrated this feature in the tendermint.
(tendermint/tendermint#8213 (comment))

Suggest can have it in v0.46.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle
Copy link
Member

@alexanderbez can we integrate this into grpc-mode and just rename it to inspect mode?

@alexanderbez
Copy link
Contributor

Sorry, what are we integrating?

@tac0turtle
Copy link
Member

tendermint inspect

@alexanderbez
Copy link
Contributor

I see. So it's to add the Tendermint command into the SDK's tendermint subcommand?

@tac0turtle
Copy link
Member

yes

@mergify mergify bot closed this as completed in #11548 Apr 5, 2022
mergify bot pushed a commit that referenced this issue Apr 5, 2022
## Description

Closes: #11495 

Add the `inspect` command to the `tendermint` sub-command.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Repository owner moved this from Ready to Done in Cosmos SDK Maintenance Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants