Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmovisor pre-upgrade not found #11931

Closed
4 tasks
yaruwangway opened this issue May 11, 2022 · 4 comments · Fixed by #12005
Closed
4 tasks

cosmovisor pre-upgrade not found #11931

yaruwangway opened this issue May 11, 2022 · 4 comments · Fixed by #12005
Assignees

Comments

@yaruwangway
Copy link
Contributor

Summary of Bug

I upgrade simd from v0.45.0 (tendermint 0.34) to v0.46(tendermint 0.35), with cosmovisor pre-upgrade to run the tendermint key migration.

get err log pre-upgrade command does not exist. continuing the upgrade. module=cosmovisor

when if i manually do cosmovisor pre-upgrade, the key-migration which i put in pre-upgrade handler HandlePreUpgrade() will run.

this seems because the calling of simd pre-upgrade cannot find the command pre-upgrade. when calling simd pre-upgrade , it is still pointing to the simd old version (before upgrade). only after upgrade, the new simd has pre-upgrade.

Version

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@yaruwangway yaruwangway added the C:Cosmovisor Issues and PR related to Cosmovisor label May 11, 2022
@alexanderbez
Copy link
Contributor

@julienrbrt does this seem familiar to you?

@julienrbrt
Copy link
Member

Hey, which version of cosmovisor are you using?

@yaruwangway
Copy link
Contributor Author

v1.1.0

@yaruwangway yaruwangway mentioned this issue May 11, 2022
4 tasks
@julienrbrt julienrbrt self-assigned this May 12, 2022
@julienrbrt julienrbrt moved this to 📝 Todo in Cosmos-SDK May 12, 2022
@robert-zaremba
Copy link
Collaborator

This is a bug. We must run pre-upgrade command with a new binary.

@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK May 13, 2022
@julienrbrt julienrbrt removed T:Bug C:Cosmovisor Issues and PR related to Cosmovisor labels May 16, 2022
@julienrbrt julienrbrt moved this to In Progress in Cosmos SDK Maintenance May 19, 2022
@julienrbrt julienrbrt linked a pull request May 20, 2022 that will close this issue
19 tasks
@julienrbrt julienrbrt moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Jun 1, 2022
@mergify mergify bot closed this as completed in #12005 Jun 2, 2022
Repository owner moved this from In Progress to Done in Cosmos SDK Maintenance Jun 2, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Jun 2, 2022
mergify bot pushed a commit that referenced this issue Jun 2, 2022
## Description

Closes: #11931



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants