-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmovisor pre-upgrade not found #11931
Comments
@julienrbrt does this seem familiar to you? |
Hey, which version of |
v1.1.0 |
This is a bug. We must run pre-upgrade command with a new binary. |
19 tasks
19 tasks
4 tasks
Repository owner
moved this from In Progress
to Done
in Cosmos SDK Maintenance
Jun 2, 2022
Repository owner
moved this from 👀 Needs Review
to 👏 Done
in Cosmos-SDK
Jun 2, 2022
mergify bot
pushed a commit
that referenced
this issue
Jun 2, 2022
## Description Closes: #11931 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of Bug
I upgrade simd from v0.45.0 (tendermint 0.34) to v0.46(tendermint 0.35), with
cosmovisor pre-upgrade
to run the tendermint key migration.get err log
pre-upgrade command does not exist. continuing the upgrade. module=cosmovisor
when if i manually do
cosmovisor pre-upgrade
, the key-migration which i put in pre-upgrade handlerHandlePreUpgrade()
will run.this seems because the calling of
simd pre-upgrade
cannot find the commandpre-upgrade
. when callingsimd pre-upgrade
, it is still pointing to the simd old version (before upgrade). only after upgrade, the new simd haspre-upgrade
.Version
Steps to Reproduce
For Admin Use
The text was updated successfully, but these errors were encountered: