Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Rewrite and Simplify CLI Tests #12696

Closed
15 tasks done
tac0turtle opened this issue Jul 22, 2022 · 1 comment
Closed
15 tasks done

EPIC: Rewrite and Simplify CLI Tests #12696

tac0turtle opened this issue Jul 22, 2022 · 1 comment

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jul 22, 2022

Summary

Currently CLI tests require the use of the in-process Tendermint network defined in github.com/cosmos/cosmos-sdk/testutil/network. This necessitates the need to run the tests sequentially and with the race detector enabled. In addition, it requires too much overhead to actually run, when we don't really need a simulated network to properly test the CLI commands. Furthermore, it also, indirectly, requires the use of simapp complicating dependency management and module release workflows.

This EPIC aims at rewriting CLI tests to be completely independent of github.com/cosmos/cosmos-sdk/testutil/network, using a table-driven approach with Tendermint RPC client mocks. We will have another testing EPIC to write more through and scoped integration tests for each module.

ref: #12527

TODO

@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK Jul 22, 2022
@tac0turtle tac0turtle added the T:Epic Epics label Jul 22, 2022
@alexanderbez alexanderbez changed the title EPIC: CLI Interface tests EPIC: Rewrite and Simplify CLI Tests Jul 24, 2022
@tac0turtle
Copy link
Member Author

closing this as all modules have been migrated.

Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Nov 3, 2022
@tac0turtle tac0turtle removed this from Cosmos-SDK Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@tac0turtle and others