Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mint): CLI tests using Tendermint Mock #13059

Merged
merged 9 commits into from
Sep 1, 2022

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented Aug 26, 2022

Description

Closes: #12760
ref: #12696


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #13059 (2062f28) into main (0eacc88) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #13059   +/-   ##
=======================================
  Coverage   53.15%   53.16%           
=======================================
  Files         641      642    +1     
  Lines       54880    54959   +79     
=======================================
+ Hits        29172    29218   +46     
- Misses      23385    23412   +27     
- Partials     2323     2329    +6     
Impacted Files Coverage Δ
x/mint/client/cli/query.go 56.96% <0.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

@likhita-809 likhita-809 marked this pull request as ready for review September 1, 2022 06:36
@likhita-809 likhita-809 requested a review from a team as a code owner September 1, 2022 06:36
@likhita-809
Copy link
Contributor Author

There were no tests in x/mint/client/cli because all the tests require keeper query code.

@tac0turtle
Copy link
Member

There were no tests in x/mint/client/cli because all the tests require keeper query code.

so part of these tests should be testing the command line interface as well. not only the logic. Like you pass x command with y flags and get the expected results.

@tac0turtle tac0turtle enabled auto-merge (squash) September 1, 2022 18:13
@tac0turtle tac0turtle merged commit 3e3b225 into main Sep 1, 2022
@tac0turtle tac0turtle deleted the likhita/mint-cli-tests branch September 1, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify mint cli tests
3 participants