Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEXTUAL Value Renderers for Protobuf Enums #12712

Closed
2 tasks
amaury1093 opened this issue Jul 25, 2022 · 2 comments · Fixed by #13853
Closed
2 tasks

TEXTUAL Value Renderers for Protobuf Enums #12712

amaury1093 opened this issue Jul 25, 2022 · 2 comments · Fixed by #13853
Assignees
@amaury1093
Labels
S:orijtech Squad: OrijTech

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Jul 25, 2022 •
edited
Loading

Part of #11970

Add value renderers for Protubuf Enums, as defined in ADR-050. Only the Format method is needed for now, the Parse one can be left for later.

  • Implementation
  • Use shared test vectors with CosmJS (Ask Simon to generate them)
@amaury1093 amaury1093 mentioned this issue Jul 25, 2022
Closed
39 tasks
@amaury1093 amaury1093 moved this to 📝 Todo in Cosmos-SDK Jul 25, 2022
@odeke-em
Copy link
Collaborator

odeke-em commented Aug 5, 2022

We shall take over this issue. Thank you @AmauryM for filing it!

@odeke-em odeke-em self-assigned this Aug 5, 2022
@odeke-em odeke-em added the S:orijtech Squad: OrijTech label Aug 5, 2022
odeke-em added a commit that referenced this issue Aug 16, 2022
@odeke-em
tx/textual: add enum value renderer
fa6cbd6 
Fixes #12712
@odeke-em odeke-em mentioned this issue Aug 16, 2022
Closed
@amaury1093 amaury1093 moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Oct 18, 2022
odeke-em added a commit that referenced this issue Oct 24, 2022
@odeke-em
tx/textual: add enum value renderer
94324d7 
Fixes #12712
@amaury1093 amaury1093 mentioned this issue Nov 14, 2022
Merged
19 tasks
@amaury1093 amaury1093 assigned amaury1093 and unassigned odeke-em Nov 14, 2022
@amaury1093
Copy link
Contributor Author

Hey @odeke-em, small fyi, I went ahead and created a PR for this on top of your old one. #13853

@amaury1093 amaury1093 moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Nov 14, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Nov 23, 2022
@tac0turtle tac0turtle removed this from Cosmos-SDK Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaury1093 amaury1093

Labels
S:orijtech Squad: OrijTech
Projects
None yet
Milestone
No milestone
3 participants
@amaury1093 @odeke-em @tac0turtle