Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chain upgrade to 0.46 failed #12904

Closed
yihuang opened this issue Aug 11, 2022 · 0 comments · Fixed by #12906
Closed

chain upgrade to 0.46 failed #12904

yihuang opened this issue Aug 11, 2022 · 0 comments · Fixed by #12906
Labels
T:Bug

Comments

@yihuang
Copy link
Collaborator

yihuang commented Aug 11, 2022 •
edited
Loading

Summary of Bug

When trying to upgrade a chain to cosmos-sdk 0.46, after restart with new binary, it paniced.
GetLastCompletedUpgrade panic because the store migration (added in #11800) has not happened yet.

Version

0.46/main

Steps to Reproduce
@yihuang yihuang changed the title test upgrade to 0.46 failed chain upgrade to 0.46 failed Aug 11, 2022
yihuang added a commit to yihuang/cosmos-sdk that referenced this issue Aug 11, 2022
@yihuang
move downgrade verification after store migration
ef8c1f4 
otherwise, it panic because it expect the key is migrated
Closes: cosmos#12904
yihuang added a commit to yihuang/cosmos-sdk that referenced this issue Aug 11, 2022
@yihuang
move downgrade verification after store migration
1472d16 
otherwise, it panic because it expect the key is migrated
Closes: cosmos#12904
@yihuang yihuang mentioned this issue Aug 11, 2022
Merged
19 tasks
alexanderbez pushed a commit that referenced this issue Aug 11, 2022
@yihuang
fix: move downgrade verification after store migration (#12906)
6473e73 
* move downgrade verification after store migration

otherwise, it panic because it expect the key is migrated
Closes: #12904

* changelog
mergify bot pushed a commit that referenced this issue Aug 11, 2022
@yihuang @mergify
fix: move downgrade verification after store migration (#12906)
bbaabda 
* move downgrade verification after store migration

otherwise, it panic because it expect the key is migrated
Closes: #12904

* changelog

(cherry picked from commit 6473e73)
@0Tech 0Tech mentioned this issue Nov 21, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move downgrade verification after store migration yihuang/cosmos-sdk
2 participants
@yihuang @julienrbrt