Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger Nano S support for transactions #141

Closed
ebuchman opened this issue Jun 25, 2017 · 1 comment
Closed

Ledger Nano S support for transactions #141

ebuchman opened this issue Jun 25, 2017 · 1 comment

Comments

@ebuchman
Copy link
Member

Signing is a bit convoluted as it involves this library, light-client, and go-crypto. Mostly seems to boil down to https://github.com/tendermint/light-client/blob/master/commands/txs/helpers.go#L41

That said, we also need to let the user verify the transaction data on the device, so it will need to see and understand Basecoin transactions. Currently defined here https://github.com/tendermint/basecoin/blob/master/types/tx.go#L161 but about to be refactored!
@ethanfrey
Copy link
Contributor

Duplicate of #84

@ebuchman hope you don't mind that I close this issue and you link to the existing one?

@snyk-bot snyk-bot mentioned this issue Dec 23, 2020
Open
ParthDesai pushed a commit to ChorusOne/cosmos-sdk that referenced this issue Apr 19, 2021
@nylira @cwgoes
Merge PR cosmos#141: Add README image
ab93069
This was referenced Sep 6, 2021
Closed
Open
@snyk-bot snyk-bot mentioned this issue Jan 10, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this issue Nov 5, 2022
Closed
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
bxlkm pushed a commit to msgrfinance/cosmos-sdk that referenced this issue Dec 22, 2022
@yun-yeo
Merge pull request cosmos#141 from terra-money/feature/fix-donate
5bce8c4 
fix donate to check delegation & unbonding & redelegation entries not…
@terrorizer1980 terrorizer1980 mentioned this issue Dec 26, 2022
Closed
@dgpatelgit dgpatelgit mentioned this issue Dec 26, 2022
Open
sbellem pushed a commit to initc3/cosmos-sdk that referenced this issue Jan 27, 2023
@assafmo
Merge pull request cosmos#141 from scrtlabs/pull_rechecking_tx_check_…
1933833 
…the_sequence_number_from_osmo

From OSMO: Make rechecking tx check the sequence number
@terrorizer1980 terrorizer1980 mentioned this issue Jan 2, 2024
Closed
@dgpatelgit dgpatelgit mentioned this issue Jan 2, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue Mar 15, 2024
Closed
@dgpatelgit dgpatelgit mentioned this issue Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebuchman @ethanfrey