-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While testing cosmos-sdk, a test cleared my gaia-6002 #1461
Labels
Comments
You're right, I'm able to reproduce this locally. We should just change all the commands in the cli_tests to have a different gaiad directory |
ValarDragon
added a commit
that referenced
this issue
Jul 4, 2018
* Makes all cli tests use .test_gaiad, .test_gaiacli instead of the same directories as the default binaries * Abstracts alot of the functionality for setting up the server into a single function / file-wide constants. This is to reduce code duplication, especially since some of this functionality depends on each test setting up the keys in the same way. Closes #1461
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cosmos-sdk/cmd/gaia/cli_test/cli_test.go
Line 25 in 24a68d3
cosmos-sdk/cmd/gaia/cli_test/cli_test.go
Line 81 in 24a68d3
cosmos-sdk/cmd/gaia/cli_test/cli_test.go
Line 153 in 24a68d3
These three lines call gaiad unsafe_reset_all. It cleared my entire gaia-6002 data.
I think this type of error shouldn't be possible. It is conceivable that a validator on mainnet could accidentally test these tests, clear their blockchain data, and get slashed.
These are the only three places in testing where this command is called
The text was updated successfully, but these errors were encountered: