Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce reliance on comet libs #14726

Closed
1 of 2 tasks
tac0turtle opened this issue Jan 23, 2023 · 2 comments
Closed
1 of 2 tasks

Reduce reliance on comet libs #14726

tac0turtle opened this issue Jan 23, 2023 · 2 comments
Assignees
Labels
C: comet dependencies Pull requests that update a dependency file

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jan 23, 2023

Summary

We use a few tendermint libs throughout the codebase, this leads to the tendermint dependency bleeding throughout the repo. We should identify and migrate the libs/utils to things in the sdk.

this includes creating our own logger interface and our own logger.

We can copy the interface and then write our own logger, with filtering to not rely on Tendermint's.

Work Breakdown

Phase 1

  • Migrate testing libs and other minor things away from tendermint libs/utils
  • implement our own logger that is built against a copy of the Tendermint's interface
@tac0turtle tac0turtle added C: comet dependencies Pull requests that update a dependency file T:Sprint labels Jan 23, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jan 23, 2023
@tac0turtle tac0turtle mentioned this issue Jan 29, 2023
19 tasks
@tac0turtle tac0turtle changed the title Reduce reliance on Tendermint libs Reduce reliance on comet libs Feb 16, 2023
@tac0turtle
Copy link
Member Author

we have removed a decent majority, the rest are primarily cli for flags and cmtjson for the custom json encoding. I believe both can be removed

@tac0turtle
Copy link
Member Author

i think we maxed out everything for now. We can close this for now and finish it up in the future

@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK Apr 14, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: comet dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants