Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rand funcs to math #15043

Merged
merged 15 commits into from
Feb 18, 2023
Merged

feat: add rand funcs to math #15043

merged 15 commits into from
Feb 18, 2023

Conversation

tac0turtle
Copy link
Member

Description

Ref: #14726

this PR adds a couple rand functions used throughout the repo in order to replace the reliance of comet libs.

Wanted a gut check if people think adding the rand file to math is fine?


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:Store C:x/genutil genutil module issues labels Feb 16, 2023
math/rand.go Fixed Show fixed Hide fixed
}

func (r *Rand) reset(seed int64) {
r.rand = mrand.New(mrand.NewSource(seed))

Check failure

Code scanning / gosec

Use of weak random number generator (math/rand instead of crypto/rand)

Use of weak random number generator (math/rand instead of crypto/rand)
@tac0turtle tac0turtle marked this pull request as ready for review February 17, 2023 15:49
@tac0turtle tac0turtle requested a review from a team as a code owner February 17, 2023 15:49
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Feb 17, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Maybe we should add a changelog in math.

@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Feb 18, 2023
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 18, 2023
@github-actions github-actions bot added the C:Confix Issues and PR related to Confix label Feb 18, 2023
@github-actions github-actions bot added the C:Hubl Tool: Hubl label Feb 18, 2023
@tac0turtle tac0turtle enabled auto-merge (squash) February 18, 2023 18:28
@tac0turtle tac0turtle merged commit 2b484a2 into main Feb 18, 2023
@tac0turtle tac0turtle deleted the marko/14726_replace_rand branch February 18, 2023 18:39
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:Store C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants