-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove bytes/HexBytes #15049
Comments
Can i take this one? @tnachen @alexanderbez |
yea, part of the worskcope would need to be to double check encoding that depended on it and provide documentation on how it chnaged for clients |
ok, and where is the specific documentation that I can modify? |
You would add it to upgrading.md |
@tac0turtle I have submitted a pr that marked as |
Summary
Throughout the cosmos-sdk we have always used bytes.HexBytes from cmtbytes "github.com/cometbft/cometbft/libs/bytes". I have always questioned the need for this type even within tendermint. Its not an issue, but it would be nice to reduce the reliance on comet as a whole and remove this type if its not needed
Problem Definition
Not a problem
Proposal
Remove usage of bytes.HexBytes in order to reduce reliance of types from comet.
Who ever picks up this issue should first look if this change is breaking.
The text was updated successfully, but these errors were encountered: