Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of features for x/gov module isn't cohesive #16909

Closed
rootulp opened this issue Jul 10, 2023 · 2 comments · Fixed by #16917
Closed

List of features for x/gov module isn't cohesive #16909

rootulp opened this issue Jul 10, 2023 · 2 comments · Fixed by #16917
Assignees
Labels
T:Docs Changes and features related to documentation.

Comments

@rootulp
Copy link
Contributor

rootulp commented Jul 10, 2023

Context

on proposals on a 1 token 1 vote basis. Next is a list of features the module
currently supports:
* **Proposal submission:** Users can submit proposals with a deposit. Once the
minimum deposit is reached, the proposal enters voting period.
* **Vote:** Participants can vote on proposals that reached MinDeposit
* **Inheritance and penalties:** Delegators inherit their validator's vote if
they don't vote themselves.
* **Claiming deposit:** Users that deposited on proposals can recover their
deposits if the proposal was accepted or rejected. If the proposal was vetoed, or never entered voting period, the deposit is burned.

Problem

This list of features doesn't seem cohesive to me (someone unfamiliar with the x/gov module). I have a few questions based on it:

Questions

Users can submit proposals with a deposit. Once the
minimum deposit is reached

What is the relationship between the deposit a user submits and the minimum deposit?

or never entered voting period

When does this scenario happen?

Participants can vote on proposals that reached MinDeposit

Should this line describe that a proposal needs to be in an active voting period?

@rootulp rootulp changed the title List of features for x/gov module isn't cohesive List of features for x/gov module isn't cohesive Jul 10, 2023
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jul 10, 2023
@julienrbrt julienrbrt added T:Docs Changes and features related to documentation. and removed needs-triage Issue that needs to be triaged labels Jul 10, 2023
@likhita-809 likhita-809 self-assigned this Jul 11, 2023
@likhita-809
Copy link
Contributor

What is the relationship between the deposit a user submits and the minimum deposit?

The minimum deposit refers to the deposit collected wholly from different users to support a specific proposal. The purpose of this minimum deposit is to ensure that proposal has community support before proceeding to voting period. The user can submit an amount of deposit while submitting the proposal to show his commitment towards it. The amount is totally dependent on individual choice.
For a proposal to enter voting period, the deposits collected from all users must reach or exceed minimum deposit specified by the governance params.

When does the never entered voting period scenario happen?

This happens when the proposal never reaches its minimum deposit in the deposit period. Then that proposal is considered to be inactive and doesn't enter voting period and the deposit associated with that proposal is burned and cannot be recovered.

@likhita-809
Copy link
Contributor

@rootulp I'll raise a small PR addressing these questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants