Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit x/upgrade #1961

Closed
rootulp opened this issue Jun 19, 2023 · 2 comments · Fixed by #2072
Closed

Audit x/upgrade #1961

rootulp opened this issue Jun 19, 2023 · 2 comments · Fixed by #2072
Assignees
@rootulp
Labels
audit item is from an audit

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jun 19, 2023 •
edited
Loading

Context

https://github.com/celestiaorg/celestia-app/tree/main/x/upgrade

Proposal

  • Audit the specs and implementation
  • Update the specs if anything is missing
@rootulp rootulp added this to the Mainnet milestone Jun 19, 2023
@rootulp rootulp self-assigned this Jun 19, 2023
@rootulp rootulp added audit item is from an audit and removed needs:triage labels Jun 27, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Jun 30, 2023 •
edited
Loading

  1. I verified that legacy governance proposal fails to execute (see gist).
  2. I verified that the genesis override here applied successfully by inspecting the mocha-3 genesis.json
        "min_deposit": [
          {
            "denom": "utia",
            "amount": "10000000"
          }
        ],

@rootulp rootulp mentioned this issue Jul 10, 2023
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Jul 11, 2023

Relevant issues in upstream:

  1. Update x/gov README to describe usage on Cosmos Hub cosmos/cosmos-sdk#16908
  2. List of features for x/gov module isn't cohesive cosmos/cosmos-sdk#16909
  3. Clarify distinction between legacy proposals and non-legacy proposals cosmos/cosmos-sdk#16929

rootulp added a commit that referenced this issue Aug 2, 2023
@rootulp
chore: audit x/upgrade module (#2072)
492c3db 
Closes #1961
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
chore: audit x/upgrade module (#2072)
26219ef 
Closes celestiaorg/celestia-app#1961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
audit item is from an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: audit x/upgrade module rootulp/celestia-app
1 participant
@rootulp