Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change _ to - in all CLI commands #1955

Closed
jackzampolin opened this issue Aug 10, 2018 · 3 comments · Fixed by #1984
Closed

Change _ to - in all CLI commands #1955

jackzampolin opened this issue Aug 10, 2018 · 3 comments · Fixed by #1984
Assignees
@alexanderbez
Labels
C:CLI

Comments

@jackzampolin
Copy link
Member

jackzampolin commented Aug 10, 2018 •
edited
Loading

Currently there are a couple of commands in both gaiad and gaiacli that have _. Those need to be transitioned to - and all the relevant documentation needs to be updated. List of affected commands:

gaiad tendermint show_node_id
gaiad tendermint show_validator
gaiad unsafe_reset_all
@alexanderbez
Copy link
Contributor

I'll knock this out in #1274 I believe.

@alexanderbez alexanderbez self-assigned this Aug 10, 2018
@mslipper
Copy link
Contributor

@alexanderbez I fixed this in PR #1984 - let me know if there might be conflicts.

@zramsay
Copy link
Contributor

zramsay commented Aug 11, 2018

this should also happen in tendermint

@mslipper mslipper mentioned this issue Aug 13, 2018
Merged
mslipper added a commit to mslipper/cosmos-sdk that referenced this issue Aug 13, 2018
@mslipper
Replace _ with - in command names
4ffab9c 
CLoses cosmos#1955
cwgoes pushed a commit that referenced this issue Aug 14, 2018
@mslipper @cwgoes
Merge PR #1984: Replace _ with - in command names
8fa2c3b 
Closes #1955
fedekunze pushed a commit that referenced this issue Aug 15, 2018
@mslipper
Merge PR #1984: Replace _ with - in command names
21b44e3 
Closes #1955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change _ to - in all CLI commands mslipper/cosmos-sdk
5 participants
@mslipper @alexanderbez @ValarDragon @jackzampolin @zramsay