Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: v0.47.11 bumps x/exp and is incompatible with gogoproto 1.4.10 #20159

Closed
1 task done
fmorency opened this issue Apr 23, 2024 · 4 comments
Closed
1 task done

[Bug]: v0.47.11 bumps x/exp and is incompatible with gogoproto 1.4.10 #20159

fmorency opened this issue Apr 23, 2024 · 4 comments
Labels

Comments

@fmorency
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I updated my project to cosmos-sdk v0.47.11 and I'm getting the

type func(x *descriptorpb.FileDescriptorProto, y *descriptorpb.FileDescriptorProto) bool of func(x, y *descriptorpb.FileDescriptorProto) bool {…} does not match inferred type func(a *descriptorpb.FileDescriptorProto, b *descriptorpb.FileDescriptorProto) int for func(a E, b E) int

issue described in #18415.

The issue seems to stem from v0.47.11 bumping the x/exp package from v0.0.0-20230711153332-06a737ee72cb to v0.0.0-20230905200255-921286631fa9 in cdb519f.

Cosmos SDK Version

0.47.11

How to reproduce?

Update your project from 0.47.10 to 0.47.11 and try to build.

@fmorency fmorency added the T:Bug label Apr 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Apr 23, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Apr 23, 2024

Yes x/exp had a breaking change.
In v0.47.10+ we've added in as a replace, but some indirect deps may bump it. You'll need to add the same replace directive in your app.

Ref: #19892, #18415, #19593

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Apr 23, 2024
@julienrbrt
Copy link
Member

We cannot simply bump it as explained in the other issue. If we bump we force everyone to use the new API, and we don't introduce such breakage in a patch release.

In the future we wil remove x/exp from our direct dependencies to avoid this.

@fmorency
Copy link
Contributor Author

Thanks @julienrbrt

For the sake of posterity, one needs to add

replace golang.org/x/exp => golang.org/x/exp v0.0.0-20230711153332-06a737ee72cb

to their go.mod file.

@julienrbrt
Copy link
Member

Chiming back here, we've deleted the x/exp dependency in gogoproto 1.7.0.
Meaning versions are now compatible with all SDK versions again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants