Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simapp/v2 start crashes with panic: proto:not found when using go.mod replaces instead of go.work #20492

Closed
Tracked by #20439
kocubinski opened this issue May 30, 2024 · 4 comments · Fixed by #20412
Closed
Tracked by #20439

simapp/v2 start crashes with panic: proto:not found when using go.mod replaces instead of go.work #20492

kocubinski opened this issue May 30, 2024 · 4 comments · Fixed by #20412
Labels
C:server/v2 Issues related to server/v2

Comments

@kocubinski
Copy link
Member

No description provided.

@kocubinski kocubinski mentioned this issue May 30, 2024
Closed
21 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 30, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK May 30, 2024
@kocubinski kocubinski changed the title simapp/v2 start crashes with panic: proto: not found when using go.mod replaces instead of go.work simapp/v2 start crashes with panic: proto:not found when using go.mod replaces instead of go.work May 30, 2024
mark-rushakoff added a commit that referenced this issue May 30, 2024
@mark-rushakoff
fix: wrap errors in auto CLI service registration
d95b4bc 
The current code in #20412, when attempting to run simd, was failing
with the error:

panic: proto: not found"

Wrapping the error returned by FindDescriptorByName gave a more
informative error:

panic: failed to find descriptor for "cosmos.accounts.v1.Msg": proto: not found

However, there is an earlier root cause. The a.err field was set due to
a failure in proto.MergedRegistry but later overridden. Fixing that
early return now shows the root cause:

panic: failed to build registry cache: proto: could not resolve import "tendermint/abci/types.proto": not found

Helps #20492.
@mark-rushakoff mark-rushakoff mentioned this issue May 30, 2024
Merged
12 tasks
@tac0turtle tac0turtle added C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels May 31, 2024
@tac0turtle
Copy link
Member

fixed via 0256369

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK May 31, 2024
@coderabbitai coderabbitai bot mentioned this issue May 31, 2024
Merged
12 tasks
@mark-rushakoff
Copy link
Member

I'm not sure this should be closed yet. From commit aa0cebd (current HEAD of #20412), while in simapp/v2/simdv2, go run . start still panics, but now instead of just the terse error message panic: proto: not found, it now panics with a more detailed message: panic: failed to build registry cache: proto: could not resolve import "tendermint/abci/types.proto": not found.

As far as I've been able to trace, tendermint/abci/types.proto is a dependency of cosmos/store/streaming/abci/grpc.proto and cosmos/store/v1beta1/listening.proto. grpc depends on listening, so it seems that listening's two imports of cometbft/abci/v1/types.proto and cosmos_proto/cosmos.proto are the root cause of the tendermint/abci/types.proto: not found error.

There are three other files (proto/cosmos/base/abci/v1beta1/abci.proto, x/consensus/proto/cosmos/consensus/v1/tx.proto, and x/staking/proto/cosmos/staking/v1beta1/staking.proto) that also import "cometbft/abci/v1/types.proto"` but maybe only those first two are included in simdv2.

I don't currently know enough about how everything ties together in the protobuf dependencies to understand 1) why there is an outstanding reference to a tendermint proto file when it doesn't appear to be referenced from the comet proto files (or maybe it is referenced and I missed it), and 2) why the dependency isn't somehow automatically included here.

I'll leave it to you all to decide whether this reopens this issue or opens a new issue.

kocubinski added a commit that referenced this issue May 31, 2024
@kocubinski
fix issue #20492
fd34264
@kocubinski
Copy link
Member Author

This isn't fixed yet, but I just fixed it in fd34264

@kocubinski kocubinski reopened this May 31, 2024
@github-project-automation github-project-automation bot moved this from 🥳 Done to 📋 Backlog in Cosmos-SDK May 31, 2024
@mark-rushakoff
Copy link
Member

I can confirm that replace for store fixed it for me. Thanks.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Jun 19, 2024
@coderabbitai coderabbitai bot mentioned this issue Jun 19, 2024
Merged
12 tasks
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
@coderabbitai coderabbitai bot mentioned this issue Jul 27, 2024
Merged
12 tasks
@coderabbitai coderabbitai bot mentioned this issue Aug 7, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:server/v2 Issues related to server/v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: simapp/v2 cosmos/cosmos-sdk
3 participants
@mark-rushakoff @kocubinski @tac0turtle