Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Validator Commission Parameters in Genesis/Export #2374

Closed
4 tasks
alexanderbez opened this issue Sep 21, 2018 · 4 comments
Closed
4 tasks

Include Validator Commission Parameters in Genesis/Export #2374

alexanderbez opened this issue Sep 21, 2018 · 4 comments
Labels
C:x/staking

Comments

@alexanderbez
Copy link
Contributor

With the advent of #2365, genesis information and state dumps should include validator commission parameters.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon
Copy link
Contributor

This should be a relatively simple PR once #2232 is merged in I believe.

@rigelrozanski
Copy link
Contributor

Have you double checked that it doesn't already? GenesisState already includes the validator struct which currently has commission in it https://github.com/cosmos/cosmos-sdk/blob/develop/x/stake/types/genesis.go#L4

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Sep 24, 2018 •
edited
Loading

Mhmmm you're probably correct. I'll leave this issue open then to just verify once #2365 is merged.

@alexanderbez
Copy link
Contributor Author

Confirmed running latest develop commission data is there. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderbez @ValarDragon @rigelrozanski