R4R: Validator Commission Model

[alexanderbez]

Implement validator commission model:

• Validator structure updated to include Commission as a first class citizen type
• Create and edit validator messages handlers updated accordingly.
• Update create-validator and edit-validator CLI commands.
• Updated staking tx docs

closes: #1672
ref: #2236

---

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[ValarDragon]

I don't think this variable is necessary. You can just limit a validator to one change every 24 hours, and when they do change validate its within the max change rate. You don't need to store the last delta change.

[alexanderbez]

I was informed by @rigelrozanski that we would allow multiple changes a day as long as those changes are within the constraints of CommissionMaxChangeRate. Also, CommissionChangeToday is not new.

Are you suggesting we change and simplify the spec? This would things much easier to track.

[alexanderbez]

I think I'll go with this approach for now that you're suggesting @ValarDragon -- I'll amend if @rigelrozanski suggests otherwise.

[ValarDragon]

Awesome! Lets make a follow-up issue tagged postlaunch then

I have the PoV atm that lets table implementing convenience changes like that to postlaunch. (It is a good idea, but unnecessary atm)

[rigelrozanski]

Great suggestion - One change per day sounds fine if it will simplify the codebase :) - however we will of course still need to keep track of when the last change was made to check against - good improvement idea val!

[codecov]

Codecov Report

Merging #2365 into develop will increase coverage by 0.02%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##           develop    #2365      +/-   ##
===========================================
+ Coverage    64.77%   64.79%   +0.02%     
===========================================
  Files          137      137              
  Lines         8469     8494      +25     
===========================================
+ Hits          5486     5504      +18     
- Misses        2620     2625       +5     
- Partials       363      365       +2

[rigelrozanski]

Good work! - few suggestions herein

[alexanderbez]

@ValarDragon and @rigelrozanski address your comments 👍

[rigelrozanski]

dopeness