R4R: Distr-PR-3 More staking hooks #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
requested review from
cwgoes,
ebuchman and
zramsay
as code owners
5 tasks
rigelrozanski
changed the base branch from
develop
to
rigel/truncate-decimal
Codecov Report
@@ Coverage Diff @@
## rigel/truncate-decimal #2381 +/- ##
=========================================================
Coverage ? 64.64%
=========================================================
Files ? 136
Lines ? 8506
Branches ? 0
=========================================================
Hits ? 5499
Misses ? 2631
Partials ? 376 |
rigelrozanski
commented
Sep 22, 2018
x/stake/keeper/validator.go
Outdated
|
|
||
| // XXX remove this code - this is should be superceded by commission work that bez is doing | ||
| // get a single validator | ||
| func (k Keeper) UpdateValidatorCommission(ctx sdk.Context, addr sdk.ValAddress, newCommission sdk.Dec) sdk.Error { |
There was a problem hiding this comment.
This will be removed before this PR is merged - just need to work from #2365 to update properly
alexanderbez
suggested changes
Sep 24, 2018
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For distribution PR (ref #2236)
Merge to
develop(change base required) after Distr-PR-2 (ref #2379) mergedTargeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests (n/a I think here)
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: