Enforce line-length limits in linter

[rigelrozanski]

We should enforce the length of lines of code in the linter as to make it less arbitrary

#2236 (comment)

[cwgoes]

Decided in favor of an optional linter step - #2546 (comment).

[alessio]

Deassigning myself. I'm presently not doing work on this.

[rigelrozanski]

Having started reflecting on line lengths and code aesthetics intensely over the past while. I no longer believe the optimal solution actually contains "one size fits all" maximum line length. For instance I think that in specific situations, code can actually be much clearer when it is more compact and thus should allow for greater than 100 character lines. One key example of this is struct definition, where we provide a comment for each field on the line of the field and allow it to. I think what's important in this situation is there there is very little logic on each of these lines, Thus I could see it appropriate that these line lengths actually extend to 140 character. I think a better "max size" might be for the maximum amount of logic per line not the maximum character length.

Anyways, I no-longer think this issue's proposal is a good idea, I've started parsing out the thesis of what I know to be the optimal code aesthetic linting ruleset here: https://github.com/rigelrozanski/aes-fmt (still very much a WIP and developing ideas)

[cwgoes]

OK, I don't have a strong preference either, closing for now then.