Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Make the simulator create the new comission rate sensibly #2682

Merged
merged 5 commits into from
Nov 12, 2018
Merged

R4R: Make the simulator create the new comission rate sensibly #2682

merged 5 commits into from
Nov 12, 2018

Conversation

ValarDragon
Copy link
Contributor

Closes #2658

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests - n/a
  • Updated relevant documentation (docs/) - n/a
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon
Copy link
Contributor Author

Current error in multisim is due to the hooks issue.

cwgoes
cwgoes approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@codecov
Copy link

codecov bot commented Nov 5, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@b7daf23). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2682   +/-   ##
==========================================
  Coverage           ?   57.65%           
==========================================
  Files              ?      154           
  Lines              ?     9570           
  Branches           ?        0           
==========================================
  Hits               ?     5518           
  Misses             ?     3688           
  Partials           ?      364

@cwgoes cwgoes changed the title Make the simulator create the new comission rate sensibly R4R: Make the simulator create the new comission rate sensibly Nov 5, 2018
@cwgoes cwgoes mentioned this pull request Nov 8, 2018
Merged
5 tasks
@jackzampolin jackzampolin mentioned this pull request Nov 9, 2018
Closed
27 tasks
alexanderbez
alexanderbez approved these changes Nov 11, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ☕️

@jackzampolin jackzampolin merged commit 0345f38 into develop Nov 12, 2018
@jackzampolin jackzampolin deleted the dev/sim_msg_edit_val branch November 12, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@jaekwon jaekwon Awaiting requested review from jaekwon

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ValarDragon @alexanderbez @cwgoes @jackzampolin @rigelrozanski