-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: x/mock/simulation cleanup and re-org #2720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2720 +/- ##
========================================
Coverage 56.89% 56.89%
========================================
Files 155 155
Lines 9751 9751
========================================
Hits 5548 5548
Misses 3825 3825
Partials 378 378 |
rigelrozanski
changed the title
WIP: simulation cleanup/refactor
R4R: x/mock/simulation cleanup and re-org
Nov 8, 2018
Thanks @rigelrozanski! I did indeed review commit-by-commit, which was pretty straightforward - LGTM. Will need to be merged after #2718. |
cwgoes
approved these changes
Nov 8, 2018
ValarDragon
reviewed
Nov 8, 2018
ValarDragon
reviewed
Nov 8, 2018
ValarDragon
reviewed
Nov 8, 2018
ValarDragon
reviewed
Nov 8, 2018
ValarDragon
reviewed
Nov 8, 2018
I'm going to merge this since it has two reviews, doesn't change the state machine, and I need to work on these files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE this is rebased on
0.26
so should be merged after thatDue to the form of these changes, I suggest reviewing by just manually going through the commits (which I made many intentionally for this reason) as well as just snooping around
x/mock/simulation/
This PR cleans up the simulation module but doesn't change it's functionality. Mostly:
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: