Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txsearch pagination is incomplete #2730

Closed
4 tasks
ackratos opened this issue Nov 8, 2018 · 1 comment
Closed
4 tasks

txsearch pagination is incomplete #2730

ackratos opened this issue Nov 8, 2018 · 1 comment

Comments

@ackratos
Copy link
Contributor

ackratos commented Nov 8, 2018

Summary of Bug

https://github.com/cosmos/cosmos-sdk/blob/develop/client/tx/search.go#L98-L101

	// TODO: take these as args
	page := 0
	perPage := 100
	res, err := node.TxSearch(query, prove, page, perPage)

Is there someone working on this? I can contribute in my spare time if no.

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ackratos ackratos mentioned this issue Nov 8, 2018
Closed
@cwgoes
Copy link
Contributor

cwgoes commented Nov 8, 2018

Indeed it is incomplete - we would welcome PRs to rectify that!

@ackratos ackratos mentioned this issue Nov 27, 2018
Merged
4 tasks
@ackratos ackratos mentioned this issue Dec 27, 2018
Merged
5 tasks
ackratos added a commit to ackratos/cosmos-sdk that referenced this issue Jan 12, 2019
@ackratos
cosmos#2730 add tx search pagination related CLI/REST API parameter
06027f0
ackratos added a commit to ackratos/cosmos-sdk that referenced this issue Jan 12, 2019
@ackratos
cosmos#2730 Fix tx.height functionality broken
f752ac2
ackratos added a commit to ackratos/cosmos-sdk that referenced this issue Jan 12, 2019
@ackratos
cosmos#2730 refactor review comment
8ca0553
ackratos added a commit to ackratos/cosmos-sdk that referenced this issue Jan 12, 2019
@ackratos
cosmos#2730 refactor review comment again
8777d8c
ackratos added a commit to ackratos/cosmos-sdk that referenced this issue Jan 15, 2019
@ackratos
cosmos#2730 bring query txs tests back
7e5c3b9
cwgoes pushed a commit that referenced this issue Jan 15, 2019
@ackratos @cwgoes
Merge PR #2730: add tx search pagination related CLI/REST API parameter
916ea85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ackratos @cwgoes and others