R4R Fix Governance state import

[jackzampolin]

Fixes #3203

This fixes an issue with governance state import where proposal state changes are not properly tracked for imported proposals. cc @zmanian @sunnya97

• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

[codecov]

Codecov Report

Merging #3223 into develop will increase coverage by 0.48%.
The diff coverage is 58%.

@@             Coverage Diff             @@
##           develop    #3223      +/-   ##
===========================================
+ Coverage    54.86%   55.35%   +0.48%     
===========================================
  Files          133      134       +1     
  Lines         9552     9594      +42     
===========================================
+ Hits          5241     5311      +70     
+ Misses        3989     3951      -38     
- Partials       322      332      +10

[fedekunze]

Needs PENDING entry. Do we also need to check for the cases when the proposal Passed or was Rejected (i.e update the proposal status on those cases)?

[jackzampolin]

According to @sunnya97 those are the only proposal statuses that need to be stored. The other statuses are StatusRejected StatusPassed and StatusNil. No actions need to be taken on those, so they are ignored.

Can you provide more info on that @sunnya97?

[fedekunze]

According to @sunnya97 those are the only proposal statuses that need to be stored. The other statuses are StatusRejected StatusPassed and StatusNil. No actions need to be taken on those, so they are ignored.

@sunnya97 So when you query one of those proposals which status do we get ? Imo we should still update the status if it shows VotingPeriod...

[sunnya97]

@fedekunze Sorry, I don't understand your question.

@jackzampolin
Yeah, so this fix has to do with making sure we recreate the ActiveProposalQueue and InactiveProposalQueue upon a state import.

The InactiveProposalQueue is where proposals currently in the DepositPeriod wait, until the Deposit period runs out (checked during EndBlocker), after which they are pruned from state if they don't meet the MinDeposit.

The ActiveProposalQueue is where proposals currently in the VotingPeriod wait, until the Voting period runs out (checked during EndBlocker), after which it is tallied.

There is no queue for proposals in the StatusRejected or StatusPassed states. And the StatusNil is just a fake Status so that the "empty value" of ProposalStatus (0x00) is "nil".