Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added test for governance queues import/export fix #3247

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Jan 7, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #3247 into jack/3203-gov-import will increase coverage by 0.51%.
The diff coverage is 53.33%.

@@                   Coverage Diff                    @@
##           jack/3203-gov-import    #3247      +/-   ##
========================================================
+ Coverage                 54.84%   55.36%   +0.51%     
========================================================
  Files                       133      134       +1     
  Lines                      9561     9598      +37     
========================================================
+ Hits                       5244     5314      +70     
+ Misses                     3995     3952      -43     
- Partials                    322      332      +10

@jackzampolin jackzampolin merged commit 831e3da into jack/3203-gov-import Jan 7, 2019
@jackzampolin jackzampolin deleted the sunny/3203-gov-import branch January 7, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants