Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenTx cli command needs nodeID and IP flags #3497

Closed
sunnya97 opened this issue Feb 5, 2019 · 1 comment
Closed

GenTx cli command needs nodeID and IP flags #3497

sunnya97 opened this issue Feb 5, 2019 · 1 comment
Assignees
@alessio
Labels
C:CLI
Milestone
v0.31.0 (Launch RC)

Comments

@sunnya97
Copy link
Member

sunnya97 commented Feb 5, 2019

Currently, it only allows you to use the local machine's IP and nodeID.
@sunnya97 sunnya97 added the C:CLI label Feb 5, 2019
@sunnya97 sunnya97 added this to the v0.31.0 (Launch RC) milestone Feb 5, 2019
@alessio
Copy link
Contributor

alessio commented Feb 5, 2019

Whilst nodeID is generated from the validator's private info as per-design, gentx picks one address among the machine's network interfaces. It makes sense to let the user customise the IP address.

@alessio alessio mentioned this issue Feb 5, 2019
Merged
5 tasks
alessio pushed a commit that referenced this issue Feb 5, 2019
let users customise node's IP
98e82ff 
Plus, make gaiad init's --moniker turn
into a required argument.

closes: #3497
@jackzampolin jackzampolin assigned sunnya97 and alessio and unassigned sunnya97 Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
C:CLI
Projects
None yet
Milestone
v0.31.0 (Launch RC)
Development

No branches or pull requests
2 participants
@alessio @sunnya97