Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaiacli still uses stake denom in its docs #3833

Closed
gamarin2 opened this issue Mar 8, 2019 · 11 comments
Closed

gaiacli still uses stake denom in its docs #3833

gamarin2 opened this issue Mar 8, 2019 · 11 comments

Comments

@gamarin2
Copy link
Contributor

gamarin2 commented Mar 8, 2019

gaiacli is still using stake as its example denom in the docs.

  • In gaiad.toml when it's generated with gaiad init
  • In the CLI docs when using --help
@jackzampolin
Copy link
Member

@gamarin2 would you like to open a PR to fix this?

@yangyanqing
Copy link
Contributor

yangyanqing commented Mar 13, 2019 •
edited
Loading

Should the denom be steak ? @gamarin2 @jackzampolin

@alexanderbez
Copy link
Contributor

No. The docs should preferably say uatom.

@yangyanqing
Copy link
Contributor

No. The docs should preferably say uatom.

Is it modified like this PR #3869 ?
@alexanderbez

@yangyanqing yangyanqing mentioned this issue Mar 13, 2019
Closed
5 tasks
@alexanderbez
Copy link
Contributor

Yes, thank you very much @yangyanqing

@rigelrozanski
Copy link
Contributor

All docs specifically relating to the hub should say uatom everything sdk generic should remain stake - Additionally Flag name description changes should only use uatoms if they are a part of code within cmd/gaia - we can rename all the flag descriptions from their default in gaia though, seems like the best solution.

@yangyanqing
Copy link
Contributor

Could this issue be closed ? @gamarin2

@rigelrozanski
Copy link
Contributor

No I don't think this issue should be closed - we ought to rename flag description denoms in from gaia for all the gaia commands. This should not be a change in the SDK but in gaia

REF #3869 (comment)

@yangyanqing
Copy link
Contributor

yangyanqing commented Mar 19, 2019 •
edited
Loading

Is PR #3935 what you want ? @rigelrozanski

@rigelrozanski
Copy link
Contributor

See my comments on your PR, once corrections are made it is a useful PR however it does not address the issue I've explained in my above comment (flag Short and Long ought to be renamed in gaia)

rigelrozanski pushed a commit that referenced this issue Mar 25, 2019
@rigelrozanski
Merge PR #3935: Modify stake to uatom in gaia's doc
5c2077c 
* Modify stake to atom in gaia's doc. #3833

* Scale up the amount from atom to uatom.

* Scale up the amount from atom to uatom.

* Update docs/gaia/validators/validator-setup.md

Co-Authored-By: yangyanqing <yangyanqing.cn@gmail.com>

* modify for review
@fedekunze
Copy link
Collaborator

I believe this is solved with the new Hub/SDK docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R4R: Remove Steak Usage from Docs
6 participants
@alexanderbez @yangyanqing @jackzampolin @gamarin2 @rigelrozanski @fedekunze