Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from gometalinter to golangci-lint #3896

Closed
1 of 4 tasks
alessio opened this issue Mar 14, 2019 · 3 comments
Closed
1 of 4 tasks

Switch from gometalinter to golangci-lint #3896

alessio opened this issue Mar 14, 2019 · 3 comments
Assignees
@alessio
Labels
tooling dev tooling within the sdk
Milestone
v0.34.0

Comments

@alessio
Copy link
Contributor

alessio commented Mar 14, 2019 •
edited by alexanderbez
Loading

Our beloved gometalinter has been terminated by its own authors, who suggest now to switch over https://github.com/golangci/golangci-lint.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio alessio added the tooling dev tooling within the sdk label Mar 14, 2019
@alexanderbez
Copy link
Contributor

alexanderbez commented Mar 14, 2019 •
edited
Loading

We should do this sooner rather than later, preferably before it's officially sunsetted.

@jackzampolin jackzampolin added this to the v0.34.0 milestone Mar 16, 2019
@jackzampolin
Copy link
Member

Might as well do this around the dep changes too.

@alessio alessio self-assigned this Mar 16, 2019
alessio added a commit that referenced this issue Mar 16, 2019
@alessio
Start working on #3896
08bbde5
alessio added a commit that referenced this issue Mar 18, 2019
@alessio
Start working on #3896
849c474
@alessio alessio mentioned this issue Mar 18, 2019
Merged
5 tasks
@alessio
Copy link
Contributor Author

alessio commented Mar 18, 2019

As a side note, we'll keep running go vet separately due to golangci/golangci-lint#446

alessio added a commit that referenced this issue Mar 18, 2019
@alessio
gometalinter -> golangci-lint migration
8df582c 
{,scripts/}Makefile:
- Remove gometalinter, install golangci-lint.
- Remove distinction between tools and devtools.
  Just tools is enough.
- test_lint -> lint
  Migrating away from underscore separated names.
- Remove unnecessary targets.
- Drop tendermint/lint. Incompatbile with golangci-lint
  and no longer necessary anyway.

Port tools/gometalinter.json to .golangci.yml
Update CircleCI config accordingly.

Closes: #3896
alessio added a commit that referenced this issue Mar 19, 2019
@alessio
gometalinter -> golangci-lint migration (#3933)
cdf2b7a 
{,scripts/}Makefile:
- Remove gometalinter, install golangci-lint.
- Remove distinction between tools and devtools.
  Just tools is enough.
- test_lint -> lint
  Migrating away from underscore separated names.
- Remove unnecessary targets.
- Drop tendermint/lint. Incompatbile with golangci-lint
  and no longer necessary anyway.
- Fix misleading message in go-mod-cache.
- New ci-target to avoid download tools twice.
- Run tests with -mod=readonly.

Port tools/gometalinter.json to .golangci.yml
Update CircleCI config accordingly.

Closes: #3896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
tooling dev tooling within the sdk
Projects
None yet
Milestone
v0.34.0
Development

No branches or pull requests
3 participants
@alessio @alexanderbez @jackzampolin