Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParseDecCoins shouldn't take a semicolon as delimiter #3915

Closed
jaekwon opened this issue Mar 15, 2019 · 4 comments · Fixed by #3951
Closed

ParseDecCoins shouldn't take a semicolon as delimiter #3915

jaekwon opened this issue Mar 15, 2019 · 4 comments · Fixed by #3951
Assignees
@alexanderbez
Labels
T:Bug
Milestone
v0.34.0

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Mar 15, 2019

Commas are the only char that delimits coins Coins or DecCoins.
Semicolons are reserved for delimiting multiple Coins's or DecCoins's, not for delimiting multiple Coins or DecCoins.
@jackzampolin jackzampolin added this to the v0.34.0 milestone Mar 16, 2019
@alexanderbez
Copy link
Contributor

Actionable items:

  • Remove ; delimiting from ParseCoin/s
  • Add custom inline parsing/handling of ; in server/config.go when handling parsing minimum gas prices and call ParseCoin on each split coin string

@alexanderbez alexanderbez self-assigned this Mar 16, 2019
@alexanderbez alexanderbez mentioned this issue Mar 20, 2019
Merged
5 tasks
@yangyanqing
Copy link
Contributor

Semicolons are reserved for delimiting multiple Coins's or DecCoins's, not for delimiting multiple Coins or DecCoins.

I don't quite understand the difference between coins and coins's. Can anyone explain this to me?

@alexanderbez
Copy link
Contributor

Yeah the sentence is somewhat confusing. I think @jaekwon means that only , is reserved for delimiting dec/coins (e.g. 5atom, 2eth) where the coins reflect AND semantics and where ; is only used in delimiting min gas prices where the coins reflect OR semantics.

@yangyanqing
Copy link
Contributor

Got it! Thanks a lot! @alexanderbez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
T:Bug
Projects
None yet
Milestone
v0.34.0
Development

Successfully merging a pull request may close this issue.

Remove ';' delimiting support from ParseDecCoins cosmos/cosmos-sdk
4 participants
@jaekwon @alexanderbez @yangyanqing @jackzampolin