Remove ';' delimiting support from ParseDecCoins #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alexanderbez
requested review from
alessio,
jackzampolin,
mossid and
jaekwon
and removed request for
ebuchman
alexanderbez
added
the
T: API Breaking
Codecov Report
@@ Coverage Diff @@
## develop #3951 +/- ##
===========================================
- Coverage 60.44% 60.42% -0.03%
===========================================
Files 196 196
Lines 14488 14495 +7
===========================================
+ Hits 8757 8758 +1
- Misses 5150 5157 +7
+ Partials 581 580 -1 |
yangyanqing
suggested changes
Mar 20, 2019
alessio
reviewed
Mar 21, 2019
| } | ||
|
|
||
| gasPricesStr := strings.Split(c.MinGasPrices, ";") | ||
| gasPrices := make(sdk.DecCoins, len(gasPricesStr)) |
There was a problem hiding this comment.
? Wouldn't it be better to have a NewDecCoins(...) constructor kind of thing?
There was a problem hiding this comment.
I don't think so.
alessio
reviewed
Mar 21, 2019
cwgoes
approved these changes
Mar 22, 2019
|
With regards to parsing, I think we can create a common function. |
jackzampolin
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3915
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: