Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go modules #3919

Closed
4 tasks
strahe opened this issue Mar 17, 2019 · 2 comments
Closed
4 tasks

Use Go modules #3919

strahe opened this issue Mar 17, 2019 · 2 comments
Assignees
@alessio

Comments

@strahe
Copy link

strahe commented Mar 17, 2019 •
edited
Loading

Summary

Use Go modules,really worth a try.

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze
Copy link
Collaborator

Addressed in #3907

@alessio
Copy link
Contributor

alessio commented Mar 17, 2019

Not quite yet @fede. #3907 will address this, hence reopening

@alessio alessio reopened this Mar 17, 2019
@alessio alessio mentioned this issue Mar 17, 2019
Merged
5 tasks
@alessio alessio self-assigned this Mar 17, 2019
alessio added a commit that referenced this issue Mar 17, 2019
@alessio
replace dep with go mod
5aa88ce 
Replace sha1sum with jack's gosum and get rid of
vendor-deps.
Also don't compute hash on vendor/ contents.
Instead hash go.sum.

Disable unconvert lint check. It does not
work very well with go mod.

Remove update_vendor_deps once and for all.

Closes: #3919 #3630
alessio added a commit that referenced this issue Mar 18, 2019
@alessio
replace dep with go mod (#3907)
6ce4d5e 
Replace sha1sum with jack's gosum and get rid of
vendor-deps.
Also don't compute hash on vendor/ contents.
Instead hash go.sum.

Disable unconvert lint check. It does not
work very well with go mod.

Remove update_vendor_deps once and for all.

Upgrade to go 1.12

Closes: #3919 #3630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alessio @strahe @fedekunze