Sim refactor 1: move store decoders to modules #4847

fedekunze · 2019-08-05T16:23:54Z

split work from: #4811 (88fac24)

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

codecov · 2019-08-05T16:43:12Z

Codecov Report

Merging #4847 into master will decrease coverage by 0.38%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #4847      +/-   ##
==========================================
- Coverage   54.02%   53.63%   -0.39%     
==========================================
  Files         269      270       +1     
  Lines       17141    16982     -159     
==========================================
- Hits         9261     9109     -152     
+ Misses       7192     7184       -8     
- Partials      688      689       +1

rigelrozanski

The general approach looks good @fedekunze !

simapp/utils.go

simapp/app.go

simapp/utils.go

simapp/utils_test.go

types/store.go

x/mint/simulation/store.go

x/supply/module.go

types/module/module.go

simapp/sim_test.go

x/auth/simulation/decoder/store_test.go

client/cmd_test.go

types/store.go

…os/cosmos-sdk into fedekunze/move-sim-decoders

rigelrozanski

Approval tentative to new comments being addressed! I'm quite happy with this new code generally! 👏

simapp/utils.go

types/module/module.go

x/gov/simulation/decoder/store_test.go

x/mint/simulation/decoder/store.go

x/mint/simulation/decoder/store_test.go

x/slashing/simulation/decoder/store.go

x/slashing/simulation/decoder/store_test.go

Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>

colin-axner

just left godoc suggestions

types/module/module.go

x/params/module.go

x/mint/module.go

x/gov/module.go

x/genutil/module.go

x/genaccounts/module.go

x/distribution/module.go

Co-Authored-By: colin axner <colinaxner@berkeley.edu>

…os/cosmos-sdk into fedekunze/move-sim-decoders

alexanderbez

Great work @fedekunze; left some feedback, but over LGTM.

Also, why have x/{module}/simulation/operations/* instead of just x/{module}/simulation/*

.pending/improvements/simulation/_4847-simulation-man

types/module/module.go

fedekunze · 2019-08-13T20:17:44Z

why have x/{module}/simulation/operations/* instead of just x/{module}/simulation/*

@alexanderbez because the random messages defined there (x/{module}/simulation/operations/msgs.go) import each module's Handler. If we flatten it, it would cause circle deps.

…dekunze/move-sim-decoders

alexanderbez

ACK 🍎

@colin-axner

* move store decoders to modules * fix * module pattern * compile * update Decoders params * fix * address @colin-axner comments * Update cmd_test.go * simulation manager * mino fixes * cleanup * Apply suggestions from code review Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com> * address @rigelrozanski comments * changelog * Apply suggestions from code review Co-Authored-By: colin axner <colinaxner@berkeley.edu> * restructure modules simulation pkgs * address @alexanderbez comments * fix

fedekunze added 2 commits August 5, 2019 18:20

move store decoders to modules

84fa364

fix

687125a

module pattern

eeb0469

fedekunze added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:Simulations WIP labels Aug 6, 2019

rigelrozanski self-requested a review August 6, 2019 17:32

rigelrozanski reviewed Aug 6, 2019

View reviewed changes

simapp/utils.go Outdated Show resolved Hide resolved

simapp/app.go Outdated Show resolved Hide resolved

simapp/utils.go Show resolved Hide resolved

simapp/utils_test.go Outdated Show resolved Hide resolved

types/store.go Outdated Show resolved Hide resolved

fedekunze added 3 commits August 7, 2019 15:06

compile

5c41dd2

update Decoders params

865a5e4

fix

45a0e3c

fedekunze marked this pull request as ready for review August 7, 2019 14:59

fedekunze requested review from alessio, alexanderbez and jackzampolin as code owners August 7, 2019 14:59

fedekunze added R4R and removed WIP labels Aug 7, 2019

fedekunze requested a review from colin-axner August 7, 2019 15:00

colin-axner suggested changes Aug 7, 2019

View reviewed changes

fedekunze added 2 commits August 8, 2019 13:55

address @colin-axner comments

da6de9f

merge master

b59f37c

fedekunze changed the title ~~move sim store decoders to modules~~ Sim Refactor 1: move sim store decoders to modules Aug 8, 2019

fedekunze changed the title ~~Sim Refactor 1: move sim store decoders to modules~~ Sim refactor 1: move store decoders to modules Aug 8, 2019

colin-axner reviewed Aug 8, 2019

View reviewed changes

client/cmd_test.go Outdated Show resolved Hide resolved

client/cmd_test.go Outdated Show resolved Hide resolved

alexanderbez suggested changes Aug 8, 2019

View reviewed changes

types/store.go Show resolved Hide resolved

fedekunze and others added 4 commits August 8, 2019 21:31

Update cmd_test.go

bd71a17

merge master

3628d90

Merge branch 'fedekunze/move-sim-decoders' of https://github.com/cosm…

564b484

…os/cosmos-sdk into fedekunze/move-sim-decoders

simulation manager

fc1e72a

fedekunze added 2 commits August 9, 2019 15:33

mino fixes

cca3a19

cleanup

c48a035

fedekunze requested review from alexanderbez and colin-axner August 9, 2019 13:58

rigelrozanski approved these changes Aug 9, 2019

View reviewed changes

fedekunze and others added 3 commits August 9, 2019 19:48

Apply suggestions from code review

225bea3

Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>

address @rigelrozanski comments

9f3525b

changelog

c13ecb6

colin-axner approved these changes Aug 9, 2019

View reviewed changes

fedekunze and others added 4 commits August 10, 2019 08:05

Apply suggestions from code review

4959068

Co-Authored-By: colin axner <colinaxner@berkeley.edu>

update tests

4a4db84

Merge branch 'fedekunze/move-sim-decoders' of https://github.com/cosm…

0338964

…os/cosmos-sdk into fedekunze/move-sim-decoders

restructure modules simulation pkgs

258e3e6

alexanderbez suggested changes Aug 13, 2019

View reviewed changes

fedekunze added 2 commits August 13, 2019 22:21

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into fe…

b9d02f4

…dekunze/move-sim-decoders

address @alexanderbez comments

f615c7f

alexanderbez approved these changes Aug 13, 2019

View reviewed changes

fedekunze and others added 2 commits August 13, 2019 23:12

Merge branch 'master' into fedekunze/move-sim-decoders

3a62c18

fix

7a1b573

rigelrozanski merged commit c441ce2 into master Aug 13, 2019

rigelrozanski deleted the fedekunze/move-sim-decoders branch August 13, 2019 22:16

fedekunze mentioned this pull request Aug 23, 2019

Sim refactor 2: move GenesisState generators to modules #4838

Merged

5 tasks

fedekunze mentioned this pull request Sep 6, 2019

add unit tests for module simulations #5007

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sim refactor 1: move store decoders to modules #4847

Sim refactor 1: move store decoders to modules #4847

fedekunze commented Aug 5, 2019

codecov bot commented Aug 5, 2019 •

edited

Loading

rigelrozanski left a comment

rigelrozanski left a comment

colin-axner left a comment

alexanderbez left a comment

fedekunze commented Aug 13, 2019

alexanderbez left a comment

Sim refactor 1: move store decoders to modules #4847

Sim refactor 1: move store decoders to modules #4847

Conversation

fedekunze commented Aug 5, 2019

codecov bot commented Aug 5, 2019 • edited Loading

Codecov Report

rigelrozanski left a comment

Choose a reason for hiding this comment

rigelrozanski left a comment

Choose a reason for hiding this comment

colin-axner left a comment

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

fedekunze commented Aug 13, 2019

alexanderbez left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 5, 2019 •

edited

Loading