-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sim refactor 2: move GenesisState generators to modules #4838
Conversation
move simulation params back to modules (#4839)
…dekunze/cleanup-genState-generators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🎉
Let's not merge until we figure out why |
@fedekunze Let's turn off invariants for |
Interestingly enough, the invariants aren't run on |
@alexanderbez @rigelrozanski I'd vote for merging this as it and fix #4963 in a separate PR. cc: @tnachen |
Are you sure? test_sim_nondeterminism:
@echo "Running non-determinism test..."
@go test -mod=readonly $(SIMAPP) -run TestAppStateDeterminism -Enabled=true \
-NumBlocks=100 -BlockSize=200 -Commit=true -v -timeout 24h flag.IntVar(&flagPeriodValue, "Period", 1, "run slow invariants only once every period assertions") Seems like the default is to run every block? Also, looks like this PR updates it to run every 5 blocks now. |
Closes: #4298
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: