'withdraw-all-rewards' Transaction Creation Error on gaiacli

[Lunagram]

Summary of Bug

gaiacli outputs 'ERROR: no RPC client defined' when i create transaction 'withdraw-all-rewards' with '--generate-only' flag.

I have tested in several environments including my local pc, server, Android.

Version

gaiacli v1.0.0-rc2
gaiacli v1.0.0-rc3

Steps to Reproduce

Just use the command below.

gaiacli tx distribution withdraw-all-rewards --from={my_address} --generate-only=true --node={my_test_node} --chain-id={my_chain_id}

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

Hmmm, good catch. This happens because you're supplying --generate-only. This means that you wish to construct the transaction "offline" (i.e. perform no queries).

However, the withdraw-all-rewards is special here because it requires a lookup of all the validators (behind the scenes):

// retrieve the comprehensive list of all validators which the
// delegator had submitted delegations to
bz, err := QueryDelegatorValidators(cliCtx, queryRoute, delegatorAddr)
if err != nil {
	return nil, err
}

This command will obviously work without --generate-only. So I'm not sure what the best course of action is here. We probably have to disable this command when --generate-only is given 🙁

/cc @jackzampolin

[Lunagram]

Thanks for your answer.
Good luck:)

[okwme]

Re-opening to discuss further possible solutions to this problem, as it presents an opportunity to improve the user experience of secure offline signing. The PR that closed the issue originally is a fix for basically an uncaught error. I'd like to discuss further the possibility of fixing the error.

Probably changing the purpose of --generate-only from being an offline only command is not something we want to do. Some alternative options would be:

• Modify the withdraw-all-rewards to take an optional delegator flag that could be used over the --from flag, but that's also a bit hacky.
• Modify the withdraw-all-rewards to accept an optional list of validators to withdraw from?
• Do nothing and explain that the only way to withdraw all rewards with offline signing is to create each withdraw manually for each validator you're delegated to, then combine them into one transaction and sign that.

[okwme]

looks like this is being addressed in #5810
i'm closing in favor of #5448