Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --generate-only also take --offline optionally #5448

Closed
jaekwon opened this issue Dec 24, 2019 · 2 comments · Fixed by #5810
Closed

Make --generate-only also take --offline optionally #5448

jaekwon opened this issue Dec 24, 2019 · 2 comments · Fixed by #5810

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Dec 24, 2019

The bug

The instructions here are broken: https://hub.cosmos.network/docs/delegator-guide-cli.html#signing-transactions-from-an-offline-computer
Running the above gives error ERROR: cannot estimate gas with generate-only

The feature

From Bez:

The generate only flag currently is dual purpose — to generate a tx only and not broadcast it and to also be completely offline while doing so. It’ll probably be a UX improvement if we introduce two distinct flags — generate only and offline.

@jaekwon jaekwon transferred this issue from cosmos/gaia Dec 24, 2019
@alexanderbez alexanderbez added this to the SDK Roadmap milestone Dec 26, 2019
@jgimeno
Copy link
Contributor

jgimeno commented Mar 13, 2020

@jgimeno jgimeno mentioned this issue Mar 16, 2020
11 tasks
@alessio
Copy link
Contributor

alessio commented Mar 16, 2020

@jgimeno I'm glad you're getting on with this! I'll dump here some context of conversations that we had in the past:

(note that there might be more PRs/issues)

Plus:

image

In short:

  • offline should cut connectivity off
  • generate-only should just disable access to keyring

Most importantly, the two modes should be orthogonal, e.g. neither of them shoud imply the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants