Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using a prefix store for IBC clients #5502

Closed
cwgoes opened this issue Jan 9, 2020 · 3 comments · Fixed by #5980
Closed

Switch to using a prefix store for IBC clients #5502

cwgoes opened this issue Jan 9, 2020 · 3 comments · Fixed by #5980
Assignees
@AdityaSripal
Milestone
IBC GoZ Readiness

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jan 9, 2020

Per the spec, clients should have separate namespaces so they can read/write state without being allowed to read/write outside their individual namespaces.
@cwgoes cwgoes added the x/ibc label Jan 9, 2020
@fedekunze fedekunze added this to the IBC Implementation milestone Jan 14, 2020
@cwgoes cwgoes mentioned this issue Jan 15, 2020
Closed
34 tasks
@fedekunze fedekunze mentioned this issue Jan 21, 2020
Merged
17 tasks
This was referenced Jan 28, 2020
Merged
Closed
@jackzampolin
Copy link
Member

Is this still something we want to accomplish?

@cwgoes
Copy link
Contributor Author

cwgoes commented Mar 17, 2020

Yes, it is.

@cwgoes cwgoes assigned AdityaSripal and unassigned fedekunze Mar 17, 2020
@cwgoes cwgoes modified the milestones: IBC 1.0, IBC GoZ Readiness Mar 17, 2020
@cwgoes
Copy link
Contributor Author

cwgoes commented Mar 17, 2020

@AdityaSripal Is this clear? All that's necessary here is to put each client instance in a separate prefix store prefixed with the client identifier (and adjust store keys as necessary, in accordance with the spec).

@AdityaSripal AdityaSripal mentioned this issue Mar 22, 2020
Closed
11 tasks
@AdityaSripal AdityaSripal mentioned this issue Apr 9, 2020
Merged
11 tasks
@mergify mergify bot closed this as completed in #5980 Apr 10, 2020
@colin-axner colin-axner mentioned this issue May 26, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaSripal AdityaSripal

Labels
None yet
Projects
None yet
Milestone
IBC GoZ Readiness
Development

Successfully merging a pull request may close this issue.

Fix Prefixes and Create Prefix Store for Clients cosmos/cosmos-sdk
4 participants
@jackzampolin @AdityaSripal @cwgoes @fedekunze