Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefix store for clients #5593

Closed
wants to merge 1 commit into from
Closed

prefix store for clients #5593

wants to merge 1 commit into from

Conversation

fedekunze
Copy link
Collaborator

Closes: #5502

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

jackzampolin
jackzampolin reviewed Jan 30, 2020
View reviewed changes
x/ibc/07-tendermint/keeper/verify.go
// VerifyClientConsensusState verifies a proof of the consensus state of the
// Tendermint client stored on the target machine.
func (cs ClientState) VerifyClientConsensusState(
func (k Keeper) VerifyClientConsensusState(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we moving these functions to the keeper?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are going to use a prefix store for each client

jackzampolin
jackzampolin reviewed Jan 30, 2020
View reviewed changes
x/ibc/07-tendermint/types/client_state.go

// ClientState from Tendermint tracks the current validator set, latest height,
// and a possible frozen height.
type ClientState struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we storing the headers/consensus-state? Aren't they associated with the client state?

Copy link
Collaborator Author

@fedekunze fedekunze Jan 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headers are not stored, only consensus state

@melekes melekes closed this Feb 7, 2020
@fedekunze fedekunze reopened this Feb 7, 2020
@fedekunze fedekunze closed this Feb 17, 2020
@fedekunze fedekunze deleted the fedekunze/5502-prefix-store branch February 17, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedekunze @jackzampolin @melekes