Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseapp test coverage not enough #556

Closed
1 of 3 tasks
ebuchman opened this issue Mar 3, 2018 · 6 comments · Fixed by #3468
Closed
1 of 3 tasks

baseapp test coverage not enough #556

ebuchman opened this issue Mar 3, 2018 · 6 comments · Fixed by #3468
Assignees
@alexanderbez
Labels
C:baseapp T: Tests
Milestone
v0.31.0 (Launch RC)

Comments

@ebuchman
Copy link
Member

ebuchman commented Mar 3, 2018 •
edited by jackzampolin
Loading

@ebuchman ebuchman mentioned this issue Mar 3, 2018
Closed
@martindale martindale added this to the 100% Test Coverage milestone Mar 8, 2018
@adrianbrink adrianbrink removed their assignment Apr 11, 2018
@ValarDragon ValarDragon mentioned this issue May 29, 2018
Merged
@ValarDragon
Copy link
Contributor

For getting test coverage to 100%, how should CheckTx be checked? In the tests that are currently there, and the ones I wrote in the PR, its using Check not the direct CheckTx method.

@ValarDragon
Copy link
Contributor

The parts that remain untested:
run forever in helpers.go

TraceKVStore functionality
RegisterCodespace
MountStoreWithDB
LoadVersion errors
Baseapp.NewContext
Filter errors
Bad query paths
Version queries

@alexanderbez
Copy link
Contributor

Thanks for aggregating this @ValarDragon

@jackzampolin jackzampolin changed the title baseapp: missing tests baseapp test coverage not enough Oct 12, 2018
@jackzampolin jackzampolin removed this from the 100% Test Coverage milestone Jan 28, 2019
@cwgoes cwgoes modified the milestones: v0.32.0, v0.31.0 (Launch RC) Jan 29, 2019
@cwgoes cwgoes assigned cwgoes and unassigned cwgoes Jan 30, 2019
@alexanderbez
Copy link
Contributor

Is this more or less a dup of #3259 @jackzampolin @cwgoes? Can we consolidate into a single issue?

@cwgoes
Copy link
Contributor

cwgoes commented Jan 31, 2019

I think we could combine #3259 into this, but I don't think all of #556 (comment) are tested yet.

@alexanderbez
Copy link
Contributor

OK, I shall tackle both in a single PR then.

@alexanderbez alexanderbez self-assigned this Jan 31, 2019
@alexanderbez alexanderbez mentioned this issue Feb 1, 2019
Merged
5 tasks
MSalopek pushed a commit to MSalopek/cosmos-sdk that referenced this issue Apr 12, 2024
@czarcas7ic
gracefully log when pruning error (cosmos#556)
8b79e86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:baseapp T: Tests
Projects
None yet
Milestone
v0.31.0 (Launch RC)
Development

Successfully merging a pull request may close this issue.

R4R: Increase BaseApp Test Coverage cosmos/cosmos-sdk
7 participants
@martindale @ebuchman @alexanderbez @ValarDragon @jackzampolin @adrianbrink @cwgoes