Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider Code Usage in x/auth Client #5663

Closed
4 tasks
alexanderbez opened this issue Feb 18, 2020 · 1 comment
Closed
4 tasks

Reconsider Code Usage in x/auth Client #5663

alexanderbez opened this issue Feb 18, 2020 · 1 comment
Labels
C:x/auth T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@alexanderbez
Copy link
Contributor

Summary

The following was introduced in #5533 to allow x/auth to be used when needing to instantiate and use AccountRetriever. This would require an app to manually set this variable.

// x/auth/client/tx.go

// Codec defines the x/auth account codec to be used for use with the
// AccountRetriever. The application must be sure to set this to their respective
// codec that implements the Codec interface and must be the same codec that
// passed to the x/auth module.
//
// TODO:/XXX: Using a package-level global isn't ideal and we should consider
// refactoring the module manager to allow passing in the correct module codec.
var Codec authtypes.Codec

Instead, we should discover a better solution that avoids needing to manually override a variable. Note, this would be applicable for any modules who's client logic relies on serializing interfaces.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez added T: Dev UX UX for SDK developers (i.e. how to call our code) C:x/auth labels Feb 18, 2020
@alexanderbez alexanderbez mentioned this issue Feb 18, 2020
28 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/auth T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

No branches or pull requests

1 participant