Protobuf: x/auth & x/supply #5533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
tac0turtle
reviewed
Feb 15, 2020
x/auth/client/rest/rest.go
Outdated
| // AuthCodec interface and must be the same codec that passed to the x/auth | ||
| // module. | ||
| // | ||
| // TODO:/XXX: Using a package-level global isn't ideal and we should consider |
There was a problem hiding this comment.
can we open an issue as a proposal about this?
There was a problem hiding this comment.
I actually want to tackle it in this PR -- still thinking.
tac0turtle
approved these changes
Feb 17, 2020
aaronc
reviewed
Feb 17, 2020
x/auth/vesting/types/types.proto
Outdated
| // | ||
| // This type should only be used internally for testing purposes. The application's | ||
| // concrete Account type should be defined in the application-level codec. | ||
| message VestingAccount { |
There was a problem hiding this comment.
Maybe name to something like TestVestingAccount just so it isn't used mistakenly.
11 tasks
Codecov Report
@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
- Coverage 39.54% 39.42% -0.13%
==========================================
Files 326 326
Lines 29302 29014 -288
==========================================
- Hits 11588 11438 -150
+ Misses 16486 16386 -100
+ Partials 1228 1190 -38
|
This was referenced Feb 18, 2020
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol Buffer migration in
x/authbased on #5491. This PR addresses the following:x/authto protobufx/supplyto protobufinternal/sub-pkgsimapp/codec)AppModuleBasicandAppModuleGenesisto now accept a codec for modular serialization of genesis state.Codecfrom already migrated modules in favor ofModuleCdc = codec.NewHybridCodec(amino).TODO:
x/authclient logic that relies on a codec.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)