-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Pubkey Encoding #5677
Labels
Comments
11 tasks
Here is what the Tink(Google's core cryptography library) project is thinking for their protobuf key encodings. https://github.com/google/tink/blob/master/docs/WIRE-FORMAT.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to
x/auth
Protobuf encoding migration via #5533,Account.Pubkey
was refactored to be a bech32-encodedstring
instead ofcrypto.Pubkey
, where we convert when we need to. However, this is problematic when the pubkey is a multisig because bech32 limits the decoding to 90 characters which a multisig can exceed 90 chars (amino encoded).Until Tendermint allows pubkeys to be just
[]byte
slices, we must either:crypto.Pubkey
and use an adhoconeof
in the SDK.string
.I propose we go with option (2) as its the easiest. Note, this is also only temporary, as the next major release of Tendermint will allow us to use
[]byte
in conjunction withinterface_type
./cc @marbar3778 @zmanian
For Admin Use
The text was updated successfully, but these errors were encountered: