Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: gaia to master of the sdk #285

Merged
merged 12 commits into from
Feb 20, 2020
Merged

update: gaia to master of the sdk #285

merged 12 commits into from
Feb 20, 2020

Conversation

tac0turtle
Copy link
Member

  • updated gaia to use the master branch of the sdk
  • when full proto?

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle
update: gaia to master of the sdk
86a5498 
- updated gaia to use the master branch of the sdk
- when full proto?

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle self-assigned this Feb 13, 2020
@tac0turtle tac0turtle added the dependencies Pull requests that update a dependency file label Feb 13, 2020
alexanderbez
alexanderbez approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK (note, we're gonna have to redo the app-level codec at some point -- the approach I took was wrong).

@alexanderbez
Copy link
Contributor

alexanderbez commented Feb 19, 2020 •
edited
Loading

Blocked on account pubkey encoding...

ref: cosmos/cosmos-sdk#5677

@jackzampolin jackzampolin mentioned this pull request Feb 19, 2020
Merged
@alexanderbez alexanderbez merged commit 67af98d into master Feb 20, 2020
@alexanderbez alexanderbez deleted the marko/update_sdk_master branch April 23, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees

@tac0turtle tac0turtle

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tac0turtle @alexanderbez @jackzampolin @fedekunze